Closed brichet closed 1 year ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
some missing devDependencies
Do you know if that was because the cookiecutter setup was making explicit use of them, and expecting these dev dependencies to be installed via another dependency? For example via @jupyterlab/builder
.
Do you know if that was because the cookiecutter setup was making explicit use of them, and expecting these dev dependencies to be installed via another dependency? For example via
@jupyterlab/builder
.
No, it is not explicit use.
react
is a peer dependency of @rjsf/utils
, imported via @jupyterlab/settingregistry
.@type/json-schema
is also expected by @rjsf/utils
, but I don't really understand why, for me it should be included in the package.yjs
is a peer dependency of y-protocol
Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:
Still wondering why we need to explicitly list these devDependencies
.
the others are necessary to build the extension (probably for webpack): https://github.com/jupyterlab/jupyterlab/blob/a3a0e3e7abf75e53810ed7ff8037c439cbb07697/buildutils/src/ensure-repo.ts#L71-L81. But it seems that not all of them were necessary.
Normally the extension code should not have to care about these webpack dependencies, since they are already dependencies of @jupyterlab/builder
.
Asking because the same list of devDependencies
can also be found in the extension template: https://github.com/jupyterlab/extension-template
This is due to stricter check of pnpm packager about dependency specifications.
Maybe these devDependencies
could be put behind a "use pnpm?" copier flag, to remove noise for extensions staying on the default jlpm
?
Maybe these
devDependencies
could be put behind a "use pnpm?" copier flag, to remove noise for extensions staying on the defaultjlpm
?
Strict control also applies to the use of node-modules. By the way, extension-cookiecutter-ts generate an extension using node-modules: https://github.com/jupyterlab/extension-cookiecutter-ts/blob/0ba10b8e268135a9c4c0283c8498a5d8f4a62c8f/%7B%7Bcookiecutter.python_name%7D%7D/.yarnrc.yml#L3
This PR updates the extension-cookiecutter to
jupyterlab>=4.0.0a37
(with yarn3).It includes the changes of https://github.com/jupyterlab/extension-cookiecutter-ts/pull/291 by @trungleduc.
It also adds some missing devDependencies which should allow
yarn install
usingnodeLinker: pnpm
.