search

jupyterlab / extension-examples

JupyterLab Extensions by Examples
BSD 3-Clause "New" or "Revised" License
454 stars 167 forks source link

Adds a new example about documents using shared models #163

Closed hbcarlos closed 3 years ago

hbcarlos commented 3 years ago

Adds an example of how to create new documents and how to use Yjs to make collaborative documents.

jtpio commented 3 years ago

Nice, thanks for adding this!

Normally we have a Binder for this repo that should install all the example. Not sure it still builds on master right now, but this could be a fun example to have up and running on Binder.

hbcarlos commented 3 years ago

Actually, I will have to update the example once those changes are released so that we can have colours and names for users.

hbcarlos commented 3 years ago

Can we update playwright to 1.13 so we can use the drag and drop functionality?

https://github.com/hbcarlos/extension-examples/blob/21d082a23f99a628fe52c560892f3d380ed9eb8f/documents/ui-tests/tests/documents.spec.ts#L67-L71

hbcarlos commented 3 years ago

Thanks for the review. I'll apply all the changes.

fcollonval commented 3 years ago

Can we update playwright to 1.13 so we can use the drag and drop functionality?

I opened an issue #177 - it will be good to update it in a separate PR.

hbcarlos commented 3 years ago

Not sure if the test should be more robust. I'm open to suggestions on how to improve it.