search

jupyterlab / extension-examples

JupyterLab Extensions by Examples
BSD 3-Clause "New" or "Revised" License
454 stars 167 forks source link

Upgrade dependencies and update server-extension install instructions #175

Closed hbcarlos closed 3 years ago

hbcarlos commented 3 years ago

I used the script to upgrade all extensions at once and check that every extension works.

I also modified the installation instructions of the server-extension to to add the enable server extension command.

fcollonval commented 3 years ago

We need to figure out why eslint is broken :'(

hbcarlos commented 3 years ago

Could it be that it is linting files in node_modules?

fcollonval commented 3 years ago

Could it be that it is linting files in node_modules?

I don't think so. This project is not freezing its yarn.lock file and eslint is working on my local copy. But I presume that if the node modules and the yarn.lock files were removed, it will raise the same error. This sounds like new eslint dependencies were released that bring issues.

hbcarlos commented 3 years ago

Yeah, I added the package-lock.json and it has eslint v7.31.

Does the jupyter-packaging uses npm if yarn is not installed? Or if you don't indicate the build tool? https://github.com/hbcarlos/extension-examples/blob/006053e190f737c911437ab6654bc0ac386cc777/hello-world/setup.py#L70

fcollonval commented 3 years ago

Does the jupyter-packaging uses npm if yarn is not installed? Or if you don't indicate the build tool? https://github.com/hbcarlos/extension-examples/blob/006053e190f737c911437ab6654bc0ac386cc777/hello-world/setup.py#L70

Yes it does: https://github.com/jupyter/jupyter-packaging/blob/2e22a16559601a6830a2d5bb263be4ccd1a48690/jupyter_packaging/setupbase.py#L189

fcollonval commented 3 years ago

There has been lots of new release around jsdoc lately. Could try updating eslint-plugin-jsdoc to ^36.0.0 in all examples? Hopefully this will fix the problem.

hbcarlos commented 3 years ago

Thanks for these tips, @fcollonval.

I think the test failures are coming from the UI tests because of the timeout but I am not sure what to do.

fcollonval commented 3 years ago

I think the test failures are coming from the UI tests because of the timeout but I am not sure what to do.

The error is probably coming because we are downloading the latest prerelease version of JupyterLab from pypi.org (I needed 3.1). Now that 3.1 has been released, I remove the --pre option because it was downloading the 4.0 alpha in which the view menu has changed. That changes make closing the file browser code in the test not working any more.