search

jupyterlab / extension-examples

JupyterLab Extensions by Examples
BSD 3-Clause "New" or "Revised" License
454 stars 167 forks source link

Pin nodejs version #193

Closed ibdafna closed 2 years ago

ibdafna commented 2 years ago

Signed-off-by: Itay Dafna i.b.dafna@gmail.com

This addresses an issue seen in #192 where the following warning surfaces:

    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: 'eslint-plugin-jsdoc@36.1.1',
    npm WARN EBADENGINE   required: { node: '^12 || ^14 || ^16' },
    npm WARN EBADENGINE   current: { node: 'v17.8.0', npm: '8.5.5' }
    npm WARN EBADENGINE }
    npm WARN EBADENGINE Unsupported engine {
    npm WARN EBADENGINE   package: '@es-joy/jsdoccomment@0.10.8',
    npm WARN EBADENGINE   required: { node: '^12 || ^14 || ^16' },
    npm WARN EBADENGINE   current: { node: 'v17.8.0', npm: '8.5.5' }
    npm WARN EBADENGINE }

..before the installations fails. Adding the version pin seems to fix it.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: