jupyterlab / extension-examples

JupyterLab Extensions by Examples
BSD 3-Clause "New" or "Revised" License
453 stars 167 forks source link

Cannot find name "AsyncIterable' #217

Closed Max-ChenFei closed 1 year ago

Max-ChenFei commented 1 year ago

Description

$ jlpm run build:lib && jlpm run build:labextension
$ tsc
../node_modules/@jupyterlab/services/lib/event/index.d.ts(89,52): error TS2583: Cannot find name 'AsyncIterable'. Do you need to change your target library? Try changing the `lib` compiler option to 'es2018' or later

Reproduce

Just as the steps in the Markdown to build the examples

conda env create
conda activate jupyterlab-extension-examples
jlpm
jlpm build-ext

Expected behavior

Please change the targe 2017 to 2018 in tsconfig.json

Context

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

krassowski commented 1 year ago

Thanks for opening this issue!

This is a problem with JupyterLab 3.6, also discussed in https://github.com/jupyterlab/jupyterlab/issues/14029. Since you control your extension you can bump target to es2018 (see https://github.com/krassowski/jupyter-resource-usage/commit/64ddb722d250ba7abaa784e6ee81ee724952ee20) and we should update the ES target across this repository too - contributions welcome!

Max-ChenFei commented 1 year ago

@krassowski Thanks, should I create a PR for this issue?

krassowski commented 1 year ago

Please do :)

Max-ChenFei commented 1 year ago

Hi, would you like to update the verison of jupyterlab in the github action?

https://github.com/jupyterlab/extension-examples/blob/0ce165c4487e9f605e512cd7445e381fe870001b/.github/workflows/main.yml#L101