search

jupyterlab / extension-examples

JupyterLab Extensions by Examples
BSD 3-Clause "New" or "Revised" License
439 stars 167 forks source link

Cell toolbar #254

Closed brichet closed 6 months ago

brichet commented 8 months ago

Example to add cell toolbar buttons.

The buttons are displayed or not, depending on the cell type.

Fix https://github.com/jupyterlab/extension-examples/issues/227

jtpio commented 6 months ago

Thanks @brichet, this looks good!

jtpio commented 6 months ago

Looks like there are a couple of conflicts.

Also should the new example be listed in the top-level README.md? https://github.com/jupyterlab/extension-examples#develop-by-examples

brichet commented 6 months ago

Thanks @jtpio for looking this.

I rebased and fixed conflicts, and add la ink and a preview in README.

I also fixed 2 broken previews in README.

brichet commented 6 months ago

Tests are failing because https://github.com/jupyterlab/jupyterlab/pull/14838 is not merged yet.

Probably https://github.com/jupyterlab/extension-examples/pull/244 should have wait for it.

jtpio commented 6 months ago

Probably #244 should have wait for it.

Right, I don't know why the failure was ignored in that PR.

fcollonval commented 6 months ago

Probably #244 should have wait for it.

Right, I don't know why the failure was ignored in that PR.

It is a chicken egg issue - the lab doc reference the example that reference the lab doc.

fcollonval commented 6 months ago

Feel free to finish up the doc pr on lab.