search

jupyterlab / extension-template

A `copier` template for JupyterLab extensions
Creative Commons Zero v1.0 Universal
52 stars 16 forks source link

Integration Tests Failing from Build Workflow #40

Closed 0Hughman0 closed 1 year ago

0Hughman0 commented 1 year ago

Description

The build workflow fails with my JupyterLab extension on the integration tests job.

I think you can see a workflow runs here?:

https://github.com/0Hughman0/jupyter_cassini/actions/runs/5823678174/job/15791243849

I get both

[WebServer] [I 2023-08-10 16:35:28.678 ServerApp] Registered HelloWorld extension at URL path /jupyter_cassini_server
[I 2023-08-10 16:35:28.678 ServerApp] jupyter_cassini_server | extension was successfully loaded.

In the log, indicating to me that extensions are activating correctly.

However, even the extension activates test fails.

Looking at the videos generated by the Playwright output, it appears like the extension doesn't activate.

Expected behavior

I would expect these tests to pass as they pass on my local system (is Windows 10?)

Context

One potential cause, that I haven't been able to diagnose is for my extension to run, I have to modify the jlpm start command:

https://github.com/0Hughman0/jupyter_cassini/blob/00a7b22898d58a2a61dcf56c5b2ffb91ac936f1d/ui-tests/package.json#L7

Which launches the server and configures it to work with Cassini, which is the backend for this project. But I haven't made any changes to the build.yml workflow and the tests run fine on my local machine.

Thanks for your help, or any suggestions on how to diagnose.

Hugh

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

fcollonval commented 1 year ago

Hey @0Hughman0 this bug is due to the release of JupyterLab 4.0.4. It has been fixed in 4.0.5 but you will need to upgrade @jupyterlab/galata to version 5.0.5 to fix it. You can achieve this by executing jlpm up "@jupyterlab/galata" in your integration tests folder.

0Hughman0 commented 1 year ago

Thanks!

Yes they seem to be running now... still failing... but I think this time at least it's because of something I've done!

Thanks for the help.