Closed Rmarieta closed 1 year ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks @Rmarieta for reporting :+1:
Looks like this will be fixed by https://github.com/jupyter-server/jupyter_releaser/pull/522.
Actually the issue might be related to the workspaces
entry in package.json
:
@Rmarieta would you be able to try without the workspaces
field in package.json
to see if it fixes the check release?
I just tried removing the workspaces
field and the check release still does not complete, but this time with a different error (see the full log here on my repository) :
...
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0002: │ @jupyterlab/services@npm:7.0.5 doesn't provide react (p4d970), requested by @jupyterlab/settingregistry
➤ YN0002: │ @jupyterlab/testutils@npm:4.0.5 doesn't provide typescript (pd72c2), requested by @jupyterlab/testing
➤ YN0002: │ releasetest@workspace:. doesn't provide webpack (p371b1), requested by css-loader
➤ YN0002: │ releasetest@workspace:. doesn't provide webpack (p47c78), requested by source-map-loader
➤ YN0002: │ releasetest@workspace:. doesn't provide webpack (p14490), requested by style-loader
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 402ms
➤ YN0000: ┌ Post-resolution validation
Post-resolution validation
➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
➤ YN0000: └ Completed
➤ YN0000: Failed with errors in 0s 515ms
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.11.4/x64/bin/jupyter-releaser", line 8, in <module>
sys.exit(main())
^^^^^^
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1157, in __call__
return self.main(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/click/core.py", line 1078, in main
rv = self.invoke(ctx)
^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/cli.py", line 119, in invoke
util.run(hook)
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/util.py", line 94, in run
raise e
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/util.py", line 86, in run
process = tee(cmd, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/tee.py", line 159, in run
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'jlpm' returned non-zero exit status 1.
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/actions/populate_release.py", line 38, in <module>
run_action("jupyter-releaser build-npm")
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/actions/common.py", line 25, in run_action
_run(target, *args, **kwargs)
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/util.py", line 94, in run
raise e
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/util.py", line 86, in run
process = tee(cmd, **kwargs)
^^^^^^^^^^^^^^^^^^
File "/opt/hostedtoolcache/Python/3.11.4/x64/lib/python3.11/site-packages/jupyter_releaser/tee.py", line 159, in run
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command 'jupyter-releaser build-npm' returned non-zero exit status 1.
➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
This time it looks like the yarn.lock
file changes on CI.
You can try to run jlpm
locally and it will likely modify that yarn.lock
file. Then commit and push the changes.
If there are no changes locally, you may also want to ensure that you use the JupyterLab and Node.js version as on the CI. I am not sure if a different operating system could also have an impact.
➤ YN0028: │ The lockfile would have been modified by this install, which is explicitly forbidden.
This time it looks like the
yarn.lock
file changes on CI.You can try to run
jlpm
locally and it will likely modify thatyarn.lock
file. Then commit and push the changes.
It worked, thank you for your help !
Description
Could not find any related issues despite getting this error with the most simple extension and after the first commit. My issue is that some of the workflows are failing with errors that seem a bit strange to me. The error that interrupts both the
Populate Release
step of theStep 2: Publish Release
workflow and theCheck Release
of theCheck Release
workflow is the following :To explore whether that could be caused by my extension in itself, I created a new empty extension with the last version of JupyterLab, and created a new public GitHub repository to host that extension, and ended up with the same error. The
Check Release
andStep 2: Publish Release
workflows are both still failing with the same error.Reproduce
Create new public GitHub repository
Create new extension and seed the project with the template :
Push code to GitHub repository :
Then this triggers the
Check Release
workflow.Set up job
,Checkout
andBase Setup
pass butCheck Release
does not. Full log can be seen at : GitHub Actions job link.If I now also try to manually trigger both
Step 1: Prep Release
andStep 2: Publish Release
by providing myADMIN_GITHUB_TOKEN
,NPM_TOKEN
andPYPI_TOKEN
in my secrets, I also get the same error during theStep 2: Publish Release
workflow.Expected behavior
I would expect the template extension
Check Release
andStep 2: Publish Release
workflows to pass without errors if I haven't modified the source code of my extension yet.Context
Troubleshoot Output
Command Line Output
Browser Output