search

jupyterlab / extension-template

A `copier` template for JupyterLab extensions
Creative Commons Zero v1.0 Universal
52 stars 16 forks source link

Fix ui-tests #44

Closed brichet closed 11 months ago

brichet commented 11 months ago

The current project structure includes ui-tests as a workspace of the project. In the same time there is an empty yarn.lock file it the ui-test directory, meaning (for yarn) that it should be treated as a completely separated project.

This PR assumes that we should treat the ui-tests as a separated project, and remove it from the project workspaces. It also allows to modify its yarn.lock file during CI.

If we aim to treat the ui-tests as a workspace (instead of a separated project), we should probably fix the check_release test which fails with workspaces (e.g. https://github.com/QuantStack/jupyter-sql-cell/actions/runs/6198336848/job/16828578630)

welcome[bot] commented 11 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

fcollonval commented 11 months ago

FYI the releaser test will be fixed by https://github.com/jupyter-server/jupyter_releaser/pull/522

welcome[bot] commented 11 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: