Closed gplasky closed 10 months ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks for reaching out @gplasky
Would you be willing to open a PR to fix that?
Technically what need to be done is probably to change the code in the following two places:
Should become
"description": "{{ project_short_description | replace('"', '\\"') }}"
description: '{{ project_short_description | replace("'", "\\'") }}',
Description
Following the instructions in the extension tutorial, during the
copier copy https://github.com/jupyterlab/extension-template .
step, one is prompted to enter an extension description. If the user enters a single quote anywhere in the description (e.g. as an apostrophe), that will break the extension build when runningpip install -ve .
later in the instructions.Reproduce
copier
as instructed.'
) anywhere within.pip install -ve .
Inspecting
src/index.ts
at the given line number and character reveals the single quote breaking thedescription
k:v pair.Expected behavior
Single quotes provided by user in the description (or any user-submitted text) should either be escaped or stripped.
Context