Capitalize variable name (github_token -> GITHUB_TOKEN)

jupyterlab / extension-template

A `copier` template for JupyterLab extensions

Creative Commons Zero v1.0 Universal

55 stars 19 forks source link

Capitalize variable name (github_token -> GITHUB_TOKEN) #53

Closed i-aki-y closed 1 year ago

i-aki-y commented 1 year ago

Since names of secrets are case-insensitive, this PR is just for styling.

In all other places, the upper case GITHUB_TOKEN is used, so I think it would be less confusing if they were unified.

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart: