Closed fcollonval closed 2 months ago
I'm having second thought about this one as yarn will complain if corepack
is not enabled by the user. And it is not by default as this is officially still an experimental feature of NodeJS.
Should we keep that as a trick for fixing our CI instead of pushing it to everybody?
cc @jtpio @krassowski
The complaint is just a warning, right? Or does it error out?
I have found corepack to be... not a great user experience, under any condition.
On Wed, Jun 19, 2024, 04:54 Michał Krassowski @.***> wrote:
The complaint is just a warning, right? Or does it error out?
— Reply to this email directly, view it on GitHub https://github.com/jupyterlab/extension-template/pull/79#issuecomment-2178262974, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRES6SHRILQ5OI7NEZDZIFINPAVCNFSM6AAAAABJPRFQGSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZYGI3DEOJXGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>
The complaint is just a warning, right? Or does it error out?
It unfortunately errors out 😔 as can be seen there https://github.com/jupyterlab-contrib/jupyterlab-variableInspector/actions/runs/9548637850/job/26316282441
I have found corepack to be... not a great user experience, under any condition.
I agree and I'm really sad that yarn went all-in that experimental feat' that is far from stable between nodeJS versions.
So I'm gonna revert this one
This is set to avoid issue with tools like dependabot that may run a different version of yarn resulting in a different yarn.lock version.