jupyterlab / frontends-team-compass

A repository for team interaction, syncing, and handling meeting notes across the JupyterLab ecosystem.
https://jupyterlab-team-compass.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
59 stars 30 forks source link

Contributing Galata (JupyterLab UI Testing & Automation Framework) #77

Closed mbektas closed 3 years ago

mbektas commented 4 years ago

Hi everyone, on June 17th I had presented Galata at weekly dev meeting and there was very positive feedback from core developers. We as Bloomberg are interested in contributing this project to JupyterLab organization, and continue helping its development. We are ready to switch the repo over. What are the next steps in this process? Please let us know.

A brief overview of Galata:

Galata is a UI testing and automation framework custom built for JupyterLab.

Main use cases

choldgraf commented 4 years ago

whoah! that's awesome! I tend to use the UI testing framework of "demo it locally and then close my eyes and send it to production what's the worst that could happen?" This sounds more rigorous than that :-)

blink1073 commented 4 years ago

Fantastic, thanks @mbektasbbg! The steps are outlined in our Readme

ellisonbg commented 4 years ago

This is amazing work - I am strongly in favor of JupyterLab incorporating this repo

On Thu, Jul 16, 2020 at 10:35 AM Steven Silvester notifications@github.com wrote:

Fantastic, thanks @mbektasbbg https://github.com/mbektasbbg! The steps are outlined in our Readme https://github.com/jupyterlab/team-compass#contributing-extensions-to-the-jupyterlab-github-organization

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jupyterlab/team-compass/issues/77#issuecomment-659562330, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGXUATZ5N5IFYFLHL5GBDR3425VANCNFSM4O4SRXEQ .

-- Brian E. Granger

Principal Technical Program Manager, AWS AI Platform (brgrange@amazon.com) On Leave - Professor of Physics and Data Science, Cal Poly @ellisonbg on GitHub

bollwyvl commented 4 years ago

I'd be remiss to not mention robot framework here:

https://robotframework.org

I've been using it extensively on open source and day job stuff. I haven't looked over Galata, but from my experience, some differences from the above bullet points:

We've been putting some of our goodies here for jupyter-specific stuff:

https://github.com/robots-from-jupyter

krassowski commented 4 years ago

Is there a repo for Galata to learn more? Or is it closed-source at the moment?

mbektas commented 4 years ago

Fantastic, thanks @mbektasbbg! The steps are outlined in our Readme

Thanks @blink1073 , will check it out.

mbektas commented 4 years ago

Is there a repo for Galata to learn more? Or is it closed-source at the moment?

yes @krassowski, it is closed-source at the moment.

mbektas commented 4 years ago

I'd be remiss to not mention robot framework here: https://robotframework.org

@bollwyvl thanks for sharing about robot, I will look into it. I need to learn more about robot to provide proper comparison but Galata's main advantage over it would be the deep and low level interaction with JupyterLab since it is custom-built for JupyterLab.

SylvainCorlay commented 4 years ago

I would love it to be elected as a Jupyter subproject.

mbektas commented 3 years ago

Hi everyone, over the past few months I have made several enhancements and fixes to Galata and got it compatible with JupyterLab 3. @jtpio also made contributions and has been reviewing it. I think it is ready to be moved over to jupyterlab org and published for wider audience and feedback now!

jtpio commented 3 years ago

Thanks @mbektasbbg for pushing on this!

I've checked galata over the past weeks and it looks really great. It would be very useful to make it an official subproject, so JupyterLab itself could use it to do end to end and visual regression testing.

So I think we should move forward with making it open source. Then it will be easier to iterate on it and accept contributions from the community. Maybe there could be a quick demo at the next JupyterLab dev meeting? Or be discussed as part of the 4.0 roadmap.

jtpio commented 3 years ago

As a side note, this could even become a more general tool to script and generate screencasts for the documentation: https://github.com/jupyterlab/jupyterlab/issues/8776#issuecomment-784399896.

krassowski commented 3 years ago

Is it possible to checkout galata now, or is it still private/hidden?

mbektas commented 3 years ago

Is it possible to checkout galata now, or is it still private/hidden?

@krassowski it is private at the moment. I will send you invitation.

krassowski commented 3 years ago

Thanks, got it. From a very quick overview it looks like a lightweight alternative to robotframework approach. I think that both have their advantages. I would be interested to see in action. Definitely worth discussing at a dev meeting.

mbektas commented 3 years ago

Here is a screencast of Galata in action.

screencast

jtpio commented 3 years ago

During the JupyterLab dev meeting yesterday, it was decided to wait one more week before moving forward with this. So that anyone would get a chance to check it out if they would like to.

The repo is still private, but don't hesitate to comment here if you would like to get access. Thanks!

blink1073 commented 3 years ago

We've met the criteria for adoption, @mbektasbbg please feel free to proceed with the transfer.

mbektas commented 3 years ago

Thanks @blink1073 , I will do!

jtpio commented 3 years ago

Closing since galata has now been moved to the jupyterlab organization: https://github.com/jupyterlab/galata

Thanks all!