jupyterlab / hatch-jupyter-builder

A hatch plugin to help build Jupyter packages
https://hatch-jupyter-builder.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
38 stars 13 forks source link

Use tomllib from the Python 3.11+ standard library #108

Closed hroncok closed 6 months ago

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.74%. Comparing base (12ef081) to head (4eac392). Report is 23 commits behind head on main.

:exclamation: Current head 4eac392 differs from pull request most recent head 3574919. Consider uploading reports for the commit 3574919 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ======================================= Coverage 91.74% 91.74% ======================================= Files 5 5 Lines 218 218 Branches 55 55 ======================================= Hits 200 200 Misses 12 12 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hroncok commented 1 year ago

Not sure what to do with the typing test. @encukou do you know if there is a typing stub for tomllib available?

hroncok commented 1 year ago

Tests / migration fails, but does not seem related.

blink1073 commented 1 year ago

Tests / migration fails, but does not seem related.

That is correct

frenzymadness commented 6 months ago

@hroncok do you have a minute to rebase this? I hope it can be merged then.

hroncok commented 6 months ago

Rebased.

welcome[bot] commented 6 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: