search

jupyterlab / jupyter-ai

A generative AI extension for JupyterLab
https://jupyter-ai.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
3.22k stars 325 forks source link

Jupyter-releaser bumps version two times #732

Open brichet opened 7 months ago

brichet commented 7 months ago

Description

As noticed by @krassowski in https://github.com/jupyterlab-contrib/jupyter-chat/issues/15, the releaser bumps the version 2 times in the workflow, with the current settings.

Related issue: https://github.com/jupyter-server/jupyter_releaser/issues/567

Some logs from a recent check-release run:

Changes:
 - @jupyter-ai/monorepo: 2.13.0 => 2.14.0 (private)
 - @jupyter-ai/magics: 2.13.0 => 2.14.0 (private)
 - @jupyter-ai/core: 2.13.0 => 2.14.0

lerna info auto-confirmed
lerna info execute Skipping git tag/commit
lerna info execute Skipping git push
lerna info execute Skipping releases
lerna success version finished
Setting up build environment for missing dependencies
2.14.0
2.14.0
COMMAND: ../../scripts/bump-version.sh minor
lerna notice cli v6.4.1
lerna info ci enabled
lerna info current version 2.14.0
lerna notice FYI git repository validation has been skipped, please ensure your version bumps are correct
lerna WARN force-publish all packages
lerna info Assuming all packages changed
lerna info version rooted leaf detected, skipping synthetic root lifecycles
lerna WARN version Skipping working tree validation, proceed at your own risk

Changes:
 - @jupyter-ai/monorepo: 2.14.0 => 2.15.0 (private)
 - @jupyter-ai/magics: 2.14.0 => 2.15.0 (private)
 - @jupyter-ai/core: 2.14.0 => 2.15.0

Reproduce

run the check-release workflow.

Expected behavior

To bump version only once.

dlqqq commented 6 months ago

I had noticed this as well very early on, which is why this repo uses a custom bump-version.sh that is idempotent, i.e. it uses the correct version even if run multiple times. There should be an existing issue here to track this, but I don't have the time to dig it up right now.