jupyterlab / jupyter-chat

An extension to add a chat panel
BSD 3-Clause "New" or "Revised" License
12 stars 3 forks source link

Fix the release workflow #39

Closed brichet closed 1 month ago

brichet commented 1 month ago

This PR adds a script to bump version, inspired from jupyter-collaboration. This script uses lerna to bump (as before), but also bump the root package.json manually.

ATTEMPT 1: This PR remove the version from the root package.json and use the version from lerna.json as the releaser reference version. This solution avoid treating the root package.json a one of the sub-project: https://github.com/lerna/lerna/issues/2879#issuecomment-1471606448 This solution does not work with the releaser with try to run npm pack, which does not work if the version is not specified in package.json.

ATTEMPT 2: This PR add the root package.json in workspaces, but excludes the root package from Nx target: https://github.com/lerna/lerna/issues/2879#issuecomment-1454803610 With this solution the build-npm step after the bump-version step was broken, it seems that jupyterlab-collaborative-chat and jupyterlab-ws-chat were not build @jupyter/chat anymore (and still depends on it).