This PR adds a script to bump version, inspired from jupyter-collaboration. This script uses lerna to bump (as before), but also bump the root package.json manually.
ATTEMPT 1: This PR remove the version from the root package.json and use the version from lerna.json as the releaser reference version.This solution avoid treating the root package.json a one of the sub-project: https://github.com/lerna/lerna/issues/2879#issuecomment-1471606448 This solution does not work with the releaser with try to run npm pack, which does not work if the version is not specified in package.json.
ATTEMPT 2: This PR add the root package.json in workspaces, but excludes the root package from Nx target: https://github.com/lerna/lerna/issues/2879#issuecomment-1454803610 With this solution the build-npm step after the bump-version step was broken, it seems that jupyterlab-collaborative-chat and jupyterlab-ws-chat were not build @jupyter/chat anymore (and still depends on it).
This PR adds a script to bump version, inspired from
jupyter-collaboration
. This script uses lerna to bump (as before), but also bump the rootpackage.json
manually.ATTEMPT 1:
This PR remove the version from the rootpackage.json
and use the version fromlerna.json
as the releaser reference version.This solution avoid treating the rootThis solution does not work with the releaser with try to runpackage.json
a one of the sub-project: https://github.com/lerna/lerna/issues/2879#issuecomment-1471606448npm pack
, which does not work if the version is not specified inpackage.json
.ATTEMPT 2:
This PR add the rootWith this solution thepackage.json
in workspaces, but excludes the root package from Nx target: https://github.com/lerna/lerna/issues/2879#issuecomment-1454803610build-npm
step after thebump-version
step was broken, it seems thatjupyterlab-collaborative-chat
andjupyterlab-ws-chat
were not build@jupyter/chat
anymore (and still depends on it).