search

jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
140 stars 29 forks source link

Workaround shutdown issue with `aiosqlite` for now #278

Closed krassowski closed 3 months ago

krassowski commented 3 months ago

Addresses issue discussed in https://github.com/jupyterlab/jupyter-collaboration/issues/252 to help bring the CI green again.

The Windows tests are still failing though - are these indicative or Windows-specific bugs?

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a Binder on branch _krassowski/jupytercollaboration/workaround-test-failure

davidbrochart commented 3 months ago

From the macOS failure it looks like your workaround could also be applied to test_room_concurrent_initialization? The Windows failure is caused by the jupyter_server_fileid manager which does some cleanup on garbage collection, which I don't think is a good practice.

krassowski commented 3 months ago

Well, down to one failure:

image

I guess we can try to force jupyter_server_fileid to delete during the test too?

davidbrochart commented 3 months ago

But the failure means that your workaround didn't work, right?

krassowski commented 3 months ago

Not quite sure. Could it have been an interaction with jupyter_server_fileid? It is all passing now?

davidbrochart commented 3 months ago

I think it's flaky, we should rerun tests to check.

krassowski commented 3 months ago

I will close and reopen to see if we get all green again (of note Tests / Test Minimum Versions (pull_request) looks stuck right now).