search

jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
157 stars 30 forks source link

Log (instead of raise) exceptions when running as a server extension #295

Closed Zsailer closed 5 months ago

Zsailer commented 5 months ago

This supersedes some of #294, leveraging changes in pycrdt-websocket v0.13.1.

In #290, we see cases where the y-websocket server becomes unusable anytime an exception is raised within the y-websocket server's task groups. We made changes in pycrdt-websocket so that these exceptions could optionally be logged instead of raised, thereby keeping the server running.

This PR leverages those changes so we can ensure that there serve is never blocked.

We need to bump the pycrdt-websocket minimum version to get these changes.

github-actions[bot] commented 5 months ago

Binder :point_left: Launch a Binder on branch Zsailer/jupyter-collaboration/handle-exceptions