jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
140 stars 29 forks source link

Backspace not propagating to clients in the same room #308

Open ibdafna opened 1 month ago

ibdafna commented 1 month ago

When typing something in a cell, and then hitting the backspace key to delete some of the content, the deleted keystrokes do not propagate to others viewing the notebook. See attached gif.

This is happening for me on JupyterLab 4.0.x/4.1.x/4.2.x, and jupyter-collaboration==4.1.1. Downgrading to 2.0.11 doesn't solve the problem, which makes me think it's likely in one of the transient dependencies of jupyter-collaboration.

collab-issue-backspace

welcome[bot] commented 1 month ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

Zsailer commented 1 month ago

Thanks @ibdafna. I can reproduce this issue with latest jupyterlab and jupyter-collaboration as well.

jzhang20133 commented 1 month ago

This issue does not reproduce for pycrdt<=0.8.23, but reproduce when pycrdt==0.8.24. cc @ibdafna @Zsailer @davidbrochart

davidbrochart commented 1 month ago

Thanks, I've yanked pycrdt v0.8.24 for now.