search

jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
140 stars 29 forks source link

2.1.1 shows jupyterlab compatibility warning with jupyterlab 4.2 #309

Open bollwyvl opened 1 month ago

bollwyvl commented 1 month ago

Description

Noted on https://github.com/conda-forge/jupyter-collaboration-feedstock/pull/12#issuecomment-2101774026, the basic smoke test is failing for whether a user might see (or perceive) problems with their jupyterlab versions. Given the nature and complexity of this extension (and the changes in lab 4.1+), I would surprised if the 4.0.x versions in yarn.lock weren't masking some typescript-level issues. Indeed has been pinned, which is suspicious if not also provided as runtime constraints so users' package managers benefit from this wisdom in a meaningful way.

+ jupyter labextension list
JupyterLab v4.2.0
/home/conda/feedstock_root/build_artifacts/jupyter-collaboration_1715216099941/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_plac/share/jupyter/labextensions
        jupyterlab_pygments v0.3.0 enabled OK (python, jupyterlab_pygments)
        @jupyter/collaboration-extension v2.1.1 enabled  X (python, jupyter_collaboration)

   The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
        @jupyter/collaboration-extension

   If you are a user, check if an update is available for these packages.
   If you are a developer, re-run with `--verbose` flag for more details.

Disabled extensions:
    @jupyterlab/filebrowser-extension:defaultFileBrowser

Reproduce

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=930358&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=986b1512-c876-5f92-0d81-ba851554a0a3&l=935

Expected behavior

@jupyter/collaboration-extension v2.1.1 enabled  OK (python, jupyter_collaboration)

Context

    jupyter-collaboration:         2.1.1-pyhd8ed1ab_0          local      
    jupyter-lsp:                   2.2.5-pyhd8ed1ab_0          conda-forge
    jupyter_client:                8.6.1-pyhd8ed1ab_0          conda-forge
    jupyter_core:                  5.7.2-py312h7900ff3_0       conda-forge
    jupyter_events:                0.10.0-pyhd8ed1ab_0         conda-forge
    jupyter_server:                2.14.0-pyhd8ed1ab_0         conda-forge
    jupyter_server_fileid:         0.9.2-pyhd8ed1ab_0          conda-forge
    jupyter_server_terminals:      0.5.3-pyhd8ed1ab_0          conda-forge
    jupyter_ydoc:                  2.0.1-pyhd8ed1ab_0          conda-forge
    jupyterlab:                    4.2.0-pyhd8ed1ab_0          conda-forge
    jupyterlab_pygments:           0.3.0-pyhd8ed1ab_1          conda-forge
    jupyterlab_server:             2.27.1-pyhd8ed1ab_0         conda-forge
krassowski commented 1 month ago

Relevant output with verbose:

"@jupyter/collaboration-extension@2.1.1" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab         Extension           Package
>=2.0.1 <3.0.0     >=1.1.0-a0 <2.0.0   @jupyter/ydoc
krassowski commented 1 month ago

I guess we should just graduate 3.0 from alpha (which is compatible with 4.2 and in fact requires 4.2).

krassowski commented 1 month ago

Maybe we should wait with releasing 3.0 until https://github.com/jupyterlab/jupyter-collaboration/pull/307 is in.

fcollonval commented 1 month ago

Actually we can change the constraint on @jupyter/ydoc to be ^1.0.0 || ^2.0.0 because the major bump was due to the change of Python dependency but the JavaScript did not change: https://github.com/jupyter-server/jupyter_ydoc/commits/v2.0.0