search

jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
140 stars 29 forks source link

[2.x] Support @jupyter/ydoc 2.x #316

Open fcollonval opened 1 month ago

fcollonval commented 1 month ago

Fixes #309

@jupyter/ydoc 2.x is identical to 1.x - the major bump was a consequence of a change in the Python package.

github-actions[bot] commented 1 month ago

Binder :point_left: Launch a Binder on branch _fcollonval/jupyter_serverydoc/309-211-shows-jupyterlab-compatibility-warning-with-jupyterlab-42

fcollonval commented 1 month ago

On Binder build, the result of jupyter labextension list is

+ jupyter labextension list
JupyterLab v4.2.1
/srv/conda/envs/notebook/share/jupyter/labextensions
        jupyter-offlinenotebook v0.2.2 enabled  X
        jupyterlab_pygments v0.3.0 enabled OK (python, jupyterlab_pygments)
        @jupyter-widgets/jupyterlab-manager v5.0.10 enabled OK (python, jupyterlab_widgets)
        @jupyter-server/resource-usage v1.0.2 enabled OK (python, jupyter-resource-usage)
        @jupyter/collaboration-extension v2.1.1 enabled OK (python, jupyter_collaboration)

   The following extensions may be outdated or specify dependencies that are incompatible with the current version of jupyterlab:
        jupyter-offlinenotebook

   If you are a user, check if an update is available for these packages.
   If you are a developer, re-run with `--verbose` flag for more details.

Disabled extensions:
    @jupyterlab/filebrowser-extension:defaultFileBrowser
davidbrochart commented 1 month ago

Failures seem to be caused by the latest release of AnyIO. In this PR, AnyIO now emits a ResourceWarning on unclosed memory object streams. So we should either explicitly close memory object streams (best) or ignore this warning in tests.

davidbrochart commented 1 month ago

This is happening in pycrdt-websocket. Another (temporary) option would be to pin anyio <4.4.0.

fcollonval commented 1 month ago

Failures seem to be caused by the latest release of AnyIO. In this PR, AnyIO now emits a ResourceWarning on unclosed memory object streams. So we should either explicitly close memory object streams (best) or ignore this warning in tests.

Thanks for highlighting the source of the error. I add the new warning to the ignore list of pytest in 4a311c7.

davidbrochart commented 1 month ago

Thanks. I guess we should update the screenshots in the UI tests, as we did in 3.x?