jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
169 stars 31 forks source link

Bump dependencies to fix CI #335

Closed krassowski closed 3 months ago

krassowski commented 3 months ago

Fixes failing CI spotted in https://github.com/jupyterlab/jupyter-collaboration/pull/334#pullrequestreview-2232542708

github-actions[bot] commented 3 months ago

Binder :point_left: Launch a Binder on branch _krassowski/jupytercollaboration/bump-collaboration-dependencies

krassowski commented 3 months ago

Huh, it's still picking the old versions:

Collecting jupyter-collaboration-ui@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-collaboration-ui (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_collaboration_ui-1.0.0b0-py3-none-any.whl
Collecting jupyter-collaboration@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-collaboration (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_collaboration-3.0.0b0-py3-none-any.whl
Collecting jupyter-docprovider@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-docprovider (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_docprovider-1.0.0b0-py3-none-any.whl
Collecting jupyter-server-ydoc@ file:///home/runner/work/jupyter-collaboration/jupyter-collaboration/projects/jupyter-server-ydoc (from jupyter-collaboration-monorepo==3.0.0b1)
  Using cached jupyter_server_ydoc-1.0.0b0-py3-none-any.whl
krassowski commented 3 months ago

It looks like the upstream maintainer-tools pip cache does not consider dependencies further down the line:

        key: ${{ env.CACHE_PREFIX }}-pip-${{ env.PYTHON_VERSION }}-${{ hashFiles('setup.cfg', 'setup.py', '**/requirements.txt') }}

https://github.com/jupyterlab/maintainer-tools/blob/3becc873eb192cc039d37547d34495dfdf80e8af/.github/actions/base-setup/action.yml#L56-L62

krassowski commented 3 months ago

I opened https://github.com/jupyterlab/maintainer-tools/pull/244

krassowski commented 3 months ago

All green!