search

jupyterlab / jupyter-collaboration

A Jupyter Server Extension Providing Support for Y Documents
https://jupyterlab-realtime-collaboration.readthedocs.io/en/latest/
Other
168 stars 31 forks source link

Remove the extra `jlpm run build` in the workflow #380

Open jtpio opened 1 month ago

jtpio commented 1 month ago

An extra jlpm run build was added to the CI workflow in https://github.com/jupyterlab/jupyter-collaboration/pull/353:

https://github.com/jupyterlab/jupyter-collaboration/blob/c52fa207510ab6062e3ca9400cc4e71d9676c87c/.github/workflows/test.yml#L74

Although it was not clear why this was needed, as discussed here: https://github.com/jupyterlab/jupyter-collaboration/pull/353#pullrequestreview-2357605672

It would be great to check if it could be removed. Maybe it's hiding another issue of how the repo is currently set up.

cc @davidbrochart @krassowski