jupyterlab / jupyter-renderers

Renderers and renderer extensions for JupyterLab
BSD 3-Clause "New" or "Revised" License
490 stars 77 forks source link

UTF-8 BOM causes error #261

Open thehappycheese opened 3 years ago

thehappycheese commented 3 years ago

Description

Opening a UTF-8 file containing a byte order mark (BOM) causes an error and the map viewer fails to load.

Reproduce

  1. Try to open a UTF-8 .geojson file file starting with binary 0xFEFF (The UTF-8 Byte Order Mark or BOM).
  2. A popup appears reading Renderer Failure: new ims export features.geojson. Unexpected token  in JSON at position 0 See screenshot below:

Screenshot 2021-08-18 163733

Also note in the above screenshot that Jupyter's text editor also incorrectly shows the BOM as a red dot. Opening the same .geojson file in VS Code works as expected; the the BOM is hidden.

Context

The troublesome geojson file is the result of an export from an ESRI Web AppBuilder application.

welcome[bot] commented 3 years ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: