search

jupyterlab / jupyter-renderers

Renderers and renderer extensions for JupyterLab
BSD 3-Clause "New" or "Revised" License
490 stars 77 forks source link

fix: swap to @jlab-contrib/msa #264

Closed zacharyrs closed 2 years ago

zacharyrs commented 2 years ago

Swap from the unmaintained wilzbach/msa to a fork (jupyterlab-contrib/msa) with bugfixes.

This fixes issues with the MSA visualiser not displaying in new browsers. running on my laptop

I've also reverted the bio.io dependency for msa to v1.0.6 (https://github.com/jupyterlab-contrib/msa/commit/1d353efa5b59a94dc1edb14c97ecdfe9abfc99d8), which misses the latest clustal patches (https://github.com/wilzbach/bio.io/commit/233c569a000b4e481bc682dc1c5024aaa8f4c3b6).
These were not included in the latest NPM build for msa, but might be worth later incorporating. For this we'll need to fork bio.io too.

Hopefully everything is up to scratch!

Closes #258.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

zacharyrs commented 2 years ago

Sorry I didn't open it in draft state!

jtpio commented 2 years ago

@zacharyrs mind posting a quick screenshot in the top comment if you managed to get jupyerlab-fasta to run locally? (so it serves as reference, thanks!)

zacharyrs commented 2 years ago

Sure I'll do one tomorrow afternoon!

zacharyrs commented 2 years ago

@jtpio All done!

jtpio commented 2 years ago

Thanks!

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: