search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
186 stars 240 forks source link

Update to JupyterLab 3.0 #102

Closed jtpio closed 3 years ago

jtpio commented 3 years ago

Replaces https://github.com/jupyterlab/jupyterlab-demo/pull/101

Fixes #100

For now commenting out some extensions that have not been updated yet.

Can be tested with this link: https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab

TODO

jtpio commented 3 years ago

Node 14 is giving the following:

image

Trying with Node 12 instead.

jasongrout commented 3 years ago

I'm updating the docs to use https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/8f2ecb6?urlpath=lab/tree/demo in https://github.com/jupyterlab/jupyterlab/pull/9546

jasongrout commented 3 years ago

After a few seconds on that image, I get this dialog:

Build Recommended JupyterLab build is suggested:

jupyter-offlinenotebook needs to be included in build

Can we remove that plugin too, or rebuild as part of the image?

jasongrout commented 3 years ago

Can we remove that plugin too, or rebuild as part of the image?

I can't see where we are pulling in that extension. Is it part of the base binder image?

manics commented 3 years ago

I can't see where we are pulling in that extension. Is it part of the base binder image?

Yes, it's in the default repo2docker scripts. I'm going to update it to a new version that works with both JL 2 and 3, and use the new pre-built extensions system so it won't require a rebuild for JL3.

jtpio commented 3 years ago

Yes it is part of the base image and installed here:

https://github.com/jupyterhub/repo2docker/blob/560b1d96a0e39cb8de53cb41a7c2d8d23384eb82/repo2docker/buildpacks/conda/install-miniforge.bash#L60

When the switch to JupyterLab 3.0 is done in repo2docker (https://github.com/jupyterhub/repo2docker/pull/996) this should normally not be an issue anymore since the offline notebook extension will be prebuilt.

jtpio commented 3 years ago

Wondering why the popup still shows up though, since there should also be an explicit build right after:

https://github.com/jupyterhub/repo2docker/blob/560b1d96a0e39cb8de53cb41a7c2d8d23384eb82/repo2docker/buildpacks/conda/install-miniforge.bash#L61

jasongrout commented 3 years ago

Probably because it is never incorporated into lab 3 or something?

We could install the newest version of that package, which supports jlab 3 now (as of an hour ago, 0.2.0 was published)

jtpio commented 3 years ago

The latest commit explicitly installs jupyter-offlinenotebook for now to avoid having the popup:

https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/3818244?urlpath=lab

jasongrout commented 3 years ago

https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/3818244?urlpath=lab

I updated https://github.com/jupyterlab/jupyterlab/pull/9546 to use this new link

jtpio commented 3 years ago

Looks good with the jupyterlab renderers:

image

I think it's mostly bqplot left now. Linking to the PR for reference: https://github.com/bqplot/bqplot/pull/1222

jtpio commented 3 years ago

Also it seems like the Binder doesn't open with the predefined workspace anymore.

So something to have a look at too, also to make sure it's not a regression.

jtpio commented 3 years ago

For anyone willing to test the latest changes, here is the link to the Binder for this PR:

https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab

jtpio commented 3 years ago

Also it seems like the Binder doesn't open with the predefined workspace anymore.

This issue might be relevant: https://github.com/jupyterlab/jupyterlab/issues/9186

jtpio commented 3 years ago

Just added bqplot back, this is starting to look good.

image

Apart from the workspace restoration issue mentioned above, everything should work as before.

We might also want to remove jupyter-offlinenotebook=0.2 from the repo once it is part of repo2docker by default: https://github.com/jupyterhub/repo2docker/pull/997 (this could be a separate PR)

jtpio commented 3 years ago

Apart from the workspace restoration issue mentioned above, everything should work as before.

Just opened https://github.com/jupyterlab/jupyterlab/issues/9590 as it looks like there might be an issue with the restorer?

jtpio commented 3 years ago

Marking as ready for review, so the workspace issue could be addressed separately.

Instead, we can update the URL to open the Lorenz.ipynb notebook by default using the following link:

https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab/tree/demo/Lorenz.ipynb

blink1073 commented 3 years ago

I agree, thanks @saulshanabrook!