search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
185 stars 240 forks source link

Convert Makefile to Bash Script? #15

Closed jzf2101 closed 7 years ago

jzf2101 commented 7 years ago

@jasongrout suggested we convert the makefile to a Python installation script while we pin down what external content we use

jzf2101 commented 7 years ago

@ellisonbg In the meanwhile could we pull these folders in as submodules?

jzf2101 commented 7 years ago

@jasongrout looking at this script it seems as if it'd be easier to turn into a simple bash script

ellisonbg commented 7 years ago

I think we should use invoke for this:

http://www.pyinvoke.org/

On Fri, Jul 7, 2017 at 9:16 AM, jzf2101 notifications@github.com wrote:

@jasongrout https://github.com/jasongrout looking at this script it seems as if it'd be easier to turn into a simple bash script

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jupyterlab/jupyterlab-demo/issues/15#issuecomment-313726720, or mute the thread https://github.com/notifications/unsubscribe-auth/AABr0G0rOlpy5seedaUdgUCQQ7e_4Ii3ks5sLlnFgaJpZM4OJxlD .

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

jasongrout commented 7 years ago

I'm happy with a reasonable python solution. We should support Windows too

On Sat, Jul 8, 2017, 14:46 Brian E. Granger notifications@github.com wrote:

I think we should use invoke for this:

http://www.pyinvoke.org/

On Fri, Jul 7, 2017 at 9:16 AM, jzf2101 notifications@github.com wrote:

@jasongrout https://github.com/jasongrout looking at this script it seems as if it'd be easier to turn into a simple bash script

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/jupyterlab/jupyterlab-demo/issues/15#issuecomment-313726720 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AABr0G0rOlpy5seedaUdgUCQQ7e_4Ii3ks5sLlnFgaJpZM4OJxlD

.

-- Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jupyterlab/jupyterlab-demo/issues/15#issuecomment-313874181, or mute the thread https://github.com/notifications/unsubscribe-auth/AALwZtZ62GL_y_tDbB0JoAo3qLPsj66_ks5sL86agaJpZM4OJxlD .

jzf2101 commented 7 years ago

Fair enough pyinvoke it is. By that same logic the installation file should also use invoke?

jzf2101 commented 7 years ago

@ellisonbg see latest commit i now use pyinvoke