jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
186 stars 240 forks source link

Installation vs Makefile #2

Closed jzf2101 closed 7 years ago

jzf2101 commented 7 years ago

Per suggestion from @fperez , I tried installing the fork from @jasongrout but make demo doesn't handle the environment setup from INSTALL.txt Should there be changes to the makefile or readme to take care of environment setup for the demo?

jzf2101 commented 7 years ago

In #9, I'm keeping these as separate files, but I'm wondering if we should explicitly tell people to call both scripts or to run INSTALL.txt in the make file?

blink1073 commented 7 years ago

I'd say running it as bash INSTALL.txt should be good.

jzf2101 commented 7 years ago

Ok I'll create an issue to add environment instructions