search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
184 stars 242 forks source link

Enable dev build to cut down on webpack resource usage. #75

Closed ian-r-rose closed 6 years ago

ian-r-rose commented 6 years ago

Band-aid for #74. By not uglifying the build we significantly cut down on resource usage in the demo docker images.

ian-r-rose commented 6 years ago

cc @choldgraf

choldgraf commented 6 years ago

could you give an estimate on how much resource usage goes down? e.g. how long does a repo2docker build take with old vs. new?

ian-r-rose commented 6 years ago

Well, with this I don't hit the 2GB memory limit on mybinder, which I believe was the main problem.

I don't consider this to be the complete solution, more of a short-term fix while we try to tame the build a bit.

I'll get back to you on some local estimates for resource usage.

ian-r-rose commented 6 years ago

Hm, I am not seeing a huge improvement in the build times (it still takes a long time locally for me, and the webpack step is just one part of that). But I am seeing successful builds on mybinder.org, which I was not before.

choldgraf commented 6 years ago

cc @betatim or @yuvipanda or @Carreau , who helped spot-check this before. Think we can un-ban the repository if this patch is implemented?

ian-r-rose commented 6 years ago

For what it's worth, on my machine this results in about a 5 minute improvement in time (18 minutes to 13 minutes).