search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
184 stars 242 forks source link

Drop QuantStack channel and only use conda-forge #81

Closed SylvainCorlay closed 5 years ago

SylvainCorlay commented 5 years ago

Now possible since the rebuild.

ian-r-rose commented 5 years ago

Thanks for the simplification @SylvainCorlay. This looks good, except that the appveyor failure looks legitimate (it couldn't find xeus-cling). Is it possible that it hadn't made its way through the feedstock yet, or is something wrong with the windows build?

I've kicked the CI in case it's the former.

SylvainCorlay commented 5 years ago

@ian-r-rose cling and xeus-cling are not yet packaged for windows on conda-forge. It is probably not going to be in the very near future. The QuantStack channel builds exist but they are in fact not fully functional because cling 0.5 does not support windows.

SylvainCorlay commented 5 years ago

I am currious why we check the environment with appveyor since binder is linux only?

vidartf commented 5 years ago

It would be nice if the demo continues to work on Windows! I have a small demo I want to do this week, and I cannot rely on internet being present at the site.

SylvainCorlay commented 5 years ago

The thing is that the cling interpreter is not really supported on windows, so whatever build was there is not really functional.

I would be nice to be able to specify that a requirement is only required on a certain platform...

SylvainCorlay commented 5 years ago

Yeah! Thanks @ian-r-rose for pushing this forward.

ian-r-rose commented 5 years ago

Sorry for the extremely slow merge on this @SylvainCorlay, and thanks for the updates! In the interests of getting the binder back up-and-running, we'll just move forwards here without Windows builds, and figure that out later.

ian-r-rose commented 5 years ago

@SylvainCorlay I am currently seeing something broken with the xleaflet map in the C++ notebook -- does anything strike you as wrong with the current versions?

SylvainCorlay commented 5 years ago

I am afk (replying from my phone). You may need to update ipyleaflet as well.

SylvainCorlay commented 5 years ago

(Fornthe semver range check to pass, if this is the issue that you are seeing in the js console)

ian-r-rose commented 5 years ago

Ah, yep, I see the semver error in the console, good call.