search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
184 stars 242 forks source link

Jupyterlab 1.0 #91

Closed ian-r-rose closed 5 years ago

ian-r-rose commented 5 years ago

Updates to JupyterLab 1.0.

Also uses the workspaces CLI to open up the Lorenz notebook and the JupyterLab documentation side-by-side upon launching binder.

blink1073 commented 5 years ago

Thanks! Not sure what the CI fail is; I'll review in the morning

jasongrout commented 5 years ago

I updated widgets as well here.

jasongrout commented 5 years ago

Recent xeus-cling is not available on windows, apparently, so any windows CI will fail.

choldgraf commented 5 years ago

Just another note here - please tell the Binder team when you merge this, we are likely going to need to ban the jupyterlab repository until the build finishes otherwise it'll flood Binder w/ builds

jasongrout commented 5 years ago

Appveyor says:

Solving environment: ...working... failed
ResolvePackageNotFound: 
  - xeus-cling=0.6
Could not find conda environment: jupyterlab-demo

but it is right here: https://anaconda.org/conda-forge/xeus-cling/files

Travis seems to find it. Any reason why appveyor isn't finding it?

ian-r-rose commented 5 years ago

@jasongrout It's unavailable on Windows, as far as I know. So the Appveyor failure is, unfortunately, expected.

See some further discussion here: https://github.com/jupyterlab/jupyterlab-demo/pull/81

jasongrout commented 5 years ago

Thanks. I was confusing running repo2docker on windows (which should work) vs just building the env on windows.

ian-r-rose commented 5 years ago

So...perhaps it's close-to-ban-time @choldgraf?

jasongrout commented 5 years ago

Here's the binder for this branch: Binder

(currently building for me, so maybe don't click it just yet)

choldgraf commented 5 years ago

@jasongrout is the plan to link to the branch instead of master? If so that would make binder issues much more manageable

jasongrout commented 5 years ago

We were going to merge and link to the merge commit

jasongrout commented 5 years ago

Though we could just link to this commit right here that is already built, since it should basically be a fast-forward merge

choldgraf commented 5 years ago

perfect, that works great - anything other than master :-)

jasongrout commented 5 years ago

Okay, everything works great from my testing of the binder. Merging!

jasongrout commented 5 years ago

I'm building the binder for the merge commit right now.

jasongrout commented 5 years ago

Okay, we can link directly to:

https://gke.mybinder.org/v2/gh/ian-r-rose/jupyterlab-demo/c6ff54a8ca1b5d4d42aa1d03d18e32cbefc5df1e?urlpath=lab

for now, while master is still building

choldgraf commented 5 years ago

@jasongrout just a note that you in general shouldn't like to gke.mybinder.org, just link to mybinder.org

jasongrout commented 5 years ago

Thanks. I realized that before we put the actual link up :).

Things are live now on try.jupyter.org, pointing to a new stable tag in the demo repo.

jasongrout commented 5 years ago

We haven't published a blog post, but we did just announce at scipy. I'm curious how popular the jlab binders are over the next week or so.

ian-r-rose commented 5 years ago

Thanks for finishing this off @jasongrout!