search

jupyterlab / jupyterlab-demo

Demonstrations of JupyterLab
https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/master?urlpath=lab
Other
184 stars 242 forks source link

Update to JupyterLab 2.0 #92

Closed jtpio closed 4 years ago

jtpio commented 4 years ago

Fixes https://github.com/jupyterlab/jupyterlab/issues/8208

Update to JupyterLab 2.0 and bump a few other widget dependencies.

To test this PR on Binder:

Binder

blink1073 commented 4 years ago

Do you mind trying to upgrade miniconda to python 3.7 to fix the appveyor issue?

jtpio commented 4 years ago

Done, let's see how it goes.

jtpio commented 4 years ago

Now the error seems to be caused by xeus-cling that can't be installed on Windows.

It looks like this has already been discussed in https://github.com/jupyterlab/jupyterlab-demo/pull/81

blink1073 commented 4 years ago

I'd say let's drop appveyor.yml, there's no urgent need for the demo to be built on Windows.

jtpio commented 4 years ago

That sounds reasonable. For reference this was also the case when updating to JupyterLab 1.0: https://github.com/jupyterlab/jupyterlab-demo/pull/91

I'll remove appveyor and trigger another Binder build.

blink1073 commented 4 years ago

Appveyor failure is expected until we merge this. The Travis failure seemed like a connectivity issue, kicked it.

blink1073 commented 4 years ago

Thanks @jtpio!

saulshanabrook commented 4 years ago

@jtpio i think the error is because the version of jupyterlab_server is too old in binder. It needs to be at least 1.1.0: https://github.com/jupyterlab/jupyterlab/pull/8127 and it's 1.0.6.

I am not sure why it's pulling in an old version.

jtpio commented 4 years ago

This should fix it: https://github.com/conda-forge/jupyterlab-feedstock/pull/213

jtpio commented 4 years ago

To add more context, the issue mentioned here is this one: https://github.com/jupyterlab/jupyterlab/issues/8231