search

jupyterlab / jupyterlab-desktop

JupyterLab desktop application, based on Electron.
BSD 3-Clause "New" or "Revised" License
3.76k stars 365 forks source link

Ctrl-Z shortcut does not work for jupyterlab desktop v3.6.3-2 and after #804

Closed Wickdhub closed 8 months ago

Wickdhub commented 8 months ago

Description

The undo shortcut on a french laptop does not work after de 3.6.3-2 version. Instead it closes my window.

If I disable ctrl+ w behavior, nothing happens

Undo Still works if I rebind the shortcut with other keys or if I use the undo in edit menu

I guess that is because z on azerty is on the same spot as w in the qwerty

Reproduce

Expected behavior

Undo correctly

Context

Troubleshoot Output 
Paste the output from running `jupyter troubleshoot` from the terminal inside of JupyterLab Desktop here.
You may want to sanitize the paths in the output.
Browser Output (required for interface issues after loading) 
Paste the output from the DevTools JavaScript console here, if applicable.
Logs (required for issues with loading, server and startup) 
Paste the logs from the `main.log` file here (optionally also from `renderer.log`).
JasonWeill commented 8 months ago

@Wickdhub Thanks for opening this issue! Which versions have you tried? (Have you tried any 4.0.x or 4.1.x release?) What OS and version are you running? Does this happen with JupyterLab when run on its own, or is it specific to JupyterLab Desktop? Thanks!

Wickdhub commented 8 months ago

@JasonWeill Thanks for your help !

I have tried all versions after the 3.6.3-2 I believe, including 4.0.x and 4.1.x yes.

I'm running on Windows 10.

I'm pretty sure that's specific to jupyterlab desktop because my jupyterlab version do not change but works correctly on 3.6.3-1

JasonWeill commented 8 months ago

@Wickdhub Thanks for your response! Issue #709 covers the case of CTRL-Z not working on a French AZERTY keyboard. Let's continue the conversation there.