jupyterlab / jupyterlab-desktop

JupyterLab desktop application, based on Electron.
BSD 3-Clause "New" or "Revised" License
3.61k stars 344 forks source link

The version number from menu Help -> About JupyterLab does not match the actual one #846

Open blzzua opened 1 month ago

blzzua commented 1 month ago

Description

Reproduce

  1. Install any older version.
  2. Setup profile,
  3. Delete older version as package, but keep data in ~/.config/jupyterlab-desktop
  4. Install any other version.
  5. Check version using /usr/bin/jlab --version
  6. Check version using menu Help -> About JupyterLab. It does not coincide with the current one.

Expected behavior

Context

Troubleshoot Output
$ jlab --version
4.2.1-1
but same time menu Help -> About JupyterLab show this: ![Screenshot at 2024-07-16 13-01-03](https://github.com/user-attachments/assets/cd7cbd95-1487-42a4-a4b8-f961fef0a536)

When updating, the version number is not updated. As I understand it, the version number is recorded in the file $HOME/.config/jupyterlab-desktop/app-data.json while first installation, and after the update/reinstall package, the actual version number is not recorded. This is very confusing.

I saw the recommendation to delete, including deleting the profile, but then you have to delete all the settings.

blzzua commented 1 month ago

it look like the attachment from first message was not saved. here is it:

Screenshot at 2024-07-16 13-01-03

JasonWeill commented 1 month ago

From triage: JupyterLab Desktop could override JupyterLab's "about" dialog to include info about both the version of Desktop and the version of Lab. Thank you for your contribution!

krassowski commented 1 month ago

Noting down that this confusion is coming up again and again, for example recently in https://github.com/jupyterlab/jupyterlab-desktop/issues/775.