Open parmentelat opened 2 years ago
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
@parmentelat thanks for reporting. Would you mind running jupyterlab in debug mode (CLI option --debug
) and report here the log you get when opening the diff?
Related question, if you open the diff for a commit in the history panel, do you see the same error?
It is probably related to jupytext. But maybe not :wink:
Description
the extension mostly works fine for me, except when it comes to displaying the actual differences; the extension actually computes the exact set of modified files, that is fine, but when I click the +/- icon to display the actual differences, the 'new file' always comes empty - as if the file had been deleted or completely emptied - like in the following example
where in reality a cell was added to the previous release, as can be seen here:
we exclusively use jupytext-encoded notebooks, I figured maybe that could be the problem ? here this notebook uses markdown:myst as its underlying format
Reproduce
From a freshly cloned repo, containing a markdown:myst simply add a single cell to one of the notebooks, and display the differences from the git extension
Expected behavior
The differences should be displayed as the addition of that single cell; what I see is as if the file had been deleted
Context
this runs in a docker image built
FROM jupyter/scipy-notebook:latest
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.relevant section seems to be this:
Web Browser Output
*nothing seems to be relevant in the browser console*