jupyterlab / jupyterlab-git

A Git extension for JupyterLab
BSD 3-Clause "New" or "Revised" License
1.46k stars 317 forks source link

UX Bug while trying to save Credentials temporarily #1226

Open jerrygb opened 1 year ago

jerrygb commented 1 year ago

Description

We have the 0.39.0 version installed and there seems to be issue with the styling or theme where the checkbox is disabled as seen in the screenshot below.

Screen Shot 2023-02-17 at 7 15 13 AM

Could it be that some theme/user setting is causing the checkbox to behave this way?

Reproduce

  1. Go to Git Plugin
  2. Click on Clone Repository
  3. After entering the repo to clone, you have the screen for entering credentials which allows us to cache credentials. This checkbox is disabled.

Expected behavior

The checkbox is working and in conjunction with the following notebook config allows us to cache the credentials for an hour.

c.JupyterLabGit.credential_helper = 'cache --timeout=3600'

Another thing we noticed was if this was setup via git using just the terminal

git config --global credential.helper 'cache --timeout=3600'
git clone git@myrepo.git

Then invokes and sets up the credential helper and we notice the file /home/jovyan/.cache/git/credential/socket.

Context

Other labextensions (built into JupyterLab) app dir: /opt/conda/share/jupyter/lab

<!-- Results of `jupyter labextension list` -->
- Git version: 2.25.1
<!-- Results of `git --version` -->
- Operating System and its version: Linux amd64

- Jupyter version

$ jupyter --version Selected Jupyter core packages... IPython : 8.1.1 ipykernel : 5.5.5 ipywidgets : 8.0.4 jupyter_client : 7.1.2 jupyter_core : 4.9.2 jupyter_server : 1.13.5 jupyterlab : 3.0.16 nbclient : 0.5.12 nbconvert : 6.4.2 nbformat : 5.1.3 notebook : 6.4.0 qtconsole : not installed traitlets : 5.1.1


- Jupyter Paths
```$ jupyter --paths
config:
    /home/jovyan/.jupyter
    /home/jovyan/.local/etc/jupyter
    /opt/conda/etc/jupyter
    /usr/local/etc/jupyter
    /etc/jupyter
data:
    /home/jovyan/.local/share/jupyter
    /opt/conda/share/jupyter
    /usr/local/share/jupyter
    /usr/share/jupyter
runtime:
    /home/jovyan/.local/share/jupyter/runtime

We have jupyter_notebook_config.py file placed under /home/jovyan/.jupyter

welcome[bot] commented 1 year ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

fcollonval commented 1 year ago

It indeed may come from the theme. I would also try to install a more recent version of JupyterLab.