Git clone or push does not work for repositories requiring authentication

wno-xyt commented 9 months ago

Description

When trying to clone(or push) a repository using jupyterlab-git extension the following message appears:

Opening terminal and cloning or pushing the same repo with same user using cmdline works.

Reproduce

Go to 'Git -> Clone a repository'
Select a repository requiring authentication
Provide username and token
See error as per above screenshot

While reporoducing it in container I can see the following stack trace:

Context

Python package version:

(base) jovyan@27163b7383cc:~$ conda list jupyterlab-git
# packages in environment at /opt/conda:
#
# Name                    Version                   Build  Channel
jupyterlab-git            0.50.0                   pypi_0    pypi

Extension version:

jupyter labextension list
JupyterLab v4.0.9
/opt/conda/share/jupyter/labextensions
    jupyterlab_pygments v0.2.2 enabled  X (python, jupyterlab_pygments)
    nbdime-jupyterlab v3.0.1 enabled OK
    jupyterlab-plotly v5.18.0 enabled  X
    jupyter-matplotlib v0.11.3 enabled OK
    @jupyter-notebook/lab-extension v7.0.6 enabled OK
    @jupyterlab/git v0.50.0 enabled OK (python, jupyterlab-git)
    @jupyterhub/jupyter-server-proxy v4.1.0 enabled OK
    @jupyter-widgets/jupyterlab-manager v5.0.9 enabled OK (python, jupyterlab_widgets)

The following extensions are outdated:
    jupyterlab_pygments
    jupyterlab-plotly

Consider checking if an update is available for these packages.

Git version:

(base) jovyan@27163b7383cc:~$ git --version
git version 2.34.1

Operating System and its version: This is docker container (slightly modified): jupyter/scipy-notebook:x86_64-lab-4.0.7

Cloning a public repo that does not require authentication works without problems.

Any hints on how to fix this or any workarounds?

welcome[bot] commented 9 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

clabnet commented 9 months ago

Also for me, same issue.

skender18 commented 9 months ago

I got the same issue with python 3.11.6

wno-xyt commented 9 months ago

For the ones using docker image we found a workaround to have working image:

FROM jupyter/scipy-notebook:x86_64-lab-4.0.7

#Your custom stuff for image goes here.

RUN pip install git+https://github.com/pexpect/pexpect.git@master
RUN mamba install --yes \
    'jupyterlab-git==0.50.0' \
    'jupyterlab==4.0.8' && \
    mamba clean --all -f -y && \
    fix-permissions "${CONDA_DIR}" && \
    fix-permissions "/home/${NB_USER}"

With this we have a docker image with working cloning and pushing. Hope this helps.

fcollonval commented 9 months ago

Yes the issue is the one of pexpect: https://github.com/jupyterlab/jupyterlab-git/issues/1261

Closing this one as duplicate.

jupyterlab / jupyterlab-git