search

jupyterlab / jupyterlab-git

A Git extension for JupyterLab
BSD 3-Clause "New" or "Revised" License
1.45k stars 313 forks source link

Unable to set email/username on a remote server #1324

Closed jzhang20133 closed 4 months ago

jzhang20133 commented 4 months ago

Fixes https://github.com/jupyterlab/jupyterlab-git/issues/1323

welcome[bot] commented 4 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

github-actions[bot] commented 4 months ago

Binder :point_left: Launch a Binder on branch _jzhang20133/jupyterlab-git/email_usernamepopup

Zsailer commented 4 months ago

Nice! Thanks @jzhang20133!

This LGTM. @fcollonval I don't have access on this repo. Would you mind helping me merge and release a patch here? I can pick this up too if you want to give me access here.

Zsailer commented 4 months ago

Also, can you add a test?

@krassowski I dove into this a bit. It appears that we're skipping most unit tests for this panel since the JupyterLab 4 release. (see here, here, here, here, and here). I believe this is the reason the current bug wasn't detected in the first place. Removing and of the .skip calls causes these tests to fail, so it seems that the API changed somewhere along the way and the tests were never updated?

I think it's beyond the scope of this current PR to fix all of these failing unit tests. For the sake of addressing the current bug, I would propose that we merge the current PR without additional unit testing.

Further, it seems that the workflows for this repo have been failing for quite awhile due to some dependency resolution errors.

Zsailer commented 4 months ago

I've opened the following issue to track work on re-enabling the skipped unit tests (hopefully in a follow-up PR): https://github.com/jupyterlab/jupyterlab-git/issues/1325

krassowski commented 4 months ago

I don't have access on this repo. Would you mind helping me merge and release a patch here? I can pick this up too if you want to give me access here.

I've added you as a collaborator, but let's get the CI green before merging - thank you for opening https://github.com/jupyterlab/jupyterlab-git/pull/1326!

Zsailer commented 4 months ago

but let's get the CI green before merging

Done, @krassowski 🚀

I'll try to get the (skipped) unit tests working for the Git Panel. If I can't get that done today, I don't think we should block this PR.

Zsailer commented 4 months ago

Amazing work, @jzhang20133! Thank you so much for taking it the extra mile to fix all unit tests and adding a few new ones for this PR! 🚀

welcome[bot] commented 4 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

Zsailer commented 4 months ago

We'll need help with releasing this bug fix, since we don't have admin access to this repo.

I think it would be worth updating the Github workflows for releasing to use the latest work happening in Jupyter-releaser with project level PyPI tokens.

fcollonval commented 4 months ago

Thanks a lot @jzhang20133 @Zsailer and @krassowski for the latest work; v0.50.1 has been released with the latest fixes.

Zsailer commented 4 months ago

Thank you, @fcollonval! We appreciate you and @krassowski tremendously! :heart: