jupyterlab / jupyterlab-git

A Git extension for JupyterLab
BSD 3-Clause "New" or "Revised" License
1.46k stars 319 forks source link

Update for jupyterlab 3 #779

Closed ianhi closed 3 years ago

ianhi commented 4 years ago

edit - Install jupyterlab-git beta: Jupyterlab-git has a beta release which you can install with:

pip install --upgrade --pre jupyterlab-git

Description

Jupyterlab version 3 is nearly upon us (rc this week I think?). The update to jlab3 may be as simple as running: python -m jupyterlab.upgrade_extension . but what should be done w.r.t branches on this repo? Should master track jlab 3 and then create a 0.2x.y branch for bugfixes for jlab2?

fcollonval commented 4 years ago

Yes the master should follow the latest major JupyterLab. And for older JupyterLab, the branches 0.#x.y works fine.

We should also think what is required to reach 1.x => but not in an issue rather linking issue to milestone.

orome commented 3 years ago

With 3.0 I get The extension "@jupyterlab/git" is outdated.. Does this extension not currently work with 3.0?

jasongrout commented 3 years ago

With 3.0 I get The extension "@jupyterlab/git" is outdated.. Does this extension not currently work with 3.0?

This issue is not closed, and the corresponding PR (https://github.com/jupyterlab/jupyterlab-git/pull/818) has not been merged, so it's probably reasonable to assume that it hasn't been updated for 3.0 yet?

fcollonval commented 3 years ago

It is not yet release for JupyterLab 3 as it requires first nbdime to be released on it.

If you want to be notified when it will be released, you can subscribe to this issue in the right panel.

spouyllau commented 3 years ago

Hello, Have a idea of the disposability on jupyterlab 3 of jupyterlab-git ? Best,

GoingMyWay commented 3 years ago

Hello,

When will you support the jupyterlab 3?

Best

KPouianou commented 3 years ago

Is there any ETA on this? It is a serious limitation for us a we use multiple plugins that require Lab v3

fcollonval commented 3 years ago

I'm reopening as the current status is beta for JLab3 (waiting for final release of nbdime).

fcollonval commented 3 years ago

A beta version has been released for JupyterLab 3. To test it you can install it with:

pip install --pre jupyterlab-git==0.30.0b1

CC @ajbozarth

hawlcat commented 3 years ago

I tried this, and got this:

Capture

Any idea?

ianhi commented 3 years ago

I think that for jupyterlab 3 the command should be: jupyter server extension list

there's an extra space in serverextension -> server extension

hawlcat commented 3 years ago

Thank you @ianhi

I am using jupyterhub, and have this problem: image

I checked using jupyter server extension list, and jupyter labextension list to check, looks everything fine. image

If I run jupyterlab directly on the server, and everything is fine including git operation as I tried.

Anyone has any idea about this issue?

Thank you.

JessicaBarh commented 3 years ago

Thank you @ianhi

I am using jupyterhub, and have this problem: image

I checked using jupyter server extension list, and jupyter labextension list to check, looks everything fine. image

If I run jupyterlab directly on the server, and everything is fine including git operation as I tried.

Anyone has any idea about this issue?

Thank you.

Also having this issue. Any suggestions?

fcollonval commented 3 years ago

With JupyterHub and JupyterLab 3, the setting to start JupyterLab has changed - see the documentation.

To change the user’s default user interface to JupyterLab, set the following configuration option in your jupyterhub_config.py file:

c.Spawner.cmd=["jupyter-labhub"]
JessicaBarh commented 3 years ago

With JupyterHub and JupyterLab 3, the setting to start JupyterLab has changed - see the documentation.

To change the user’s default user interface to JupyterLab, set the following configuration option in your jupyterhub_config.py file:

c.Spawner.cmd=["jupyter-labhub"]

My default user interface is Jupyterlab. Would this have anything to do with nbdime? I'm using the newest beta version 3.0.0.b1

hawlcat commented 3 years ago

@JessicaBarh , FYI, I downgraded jupyterlab to 2.x, and also git. Everything goes back normal.

krassowski commented 3 years ago

@JessicaBarh what about this one: https://github.com/krassowski/jupyterlab-lsp/issues/375#issuecomment-761078622

I think predicted it will affect jupyterlab-git users here: https://github.com/jupyterlab/jupyterlab/pull/9616#issuecomment-761048731 ;)

But, seriously now, is there a way we could help JupyterHub to release a version defaulting to jupyter_server sooner? I will open an issue on jupyter-hub repo. Here it is: https://github.com/jupyterhub/jupyterhub/issues/3340

ajbozarth commented 3 years ago

What's the timeline on releasing 0.30.0 with the lab 3 support?

fcollonval commented 3 years ago

What's the timeline on releasing 0.30.0 with the lab 3 support?

We need nbdime for JLab3 to get out of beta. I think what is holding nbdime is the broken tests if you want to help with that.

reallyrandom commented 3 years ago

I am facing the exact same issue as @hawlcat and @JessicaBarh

running jupyterhub and installing in notebook server using:

pip install --pre jupyterlab-git==0.30.0b1

RUN jupyter labextension install @jupyterlab/git

Is there a workaround that doesn't require downgrading?

JessicaBarh commented 3 years ago

@william-sheldon @hawlcat I got it working using jupyter server vs jupyter notebook to start up my image. You'll also need to rename your jupyter_notebook_config.py file to jupyter_server_config.py and rename all c.NotebookApp traits to c.ServerApp in it. see https://jupyter-server.readthedocs.io/en/latest/operators/migrate-from-nbserver.html for more info

meeseeksmachine commented 3 years ago

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/jupyterlab-git-in-jupyter-hub/8108/2

stonebig commented 3 years ago

nbdime-3.0.0 is out

fcollonval commented 3 years ago

The first version supporting JupyterLab 3 (jupyterlab-git==0.30.0) has been released on pypi.org. conda release will follow soon.