jupyterlab / jupyterlab-google-drive

Cloud storage for JupyterLab using Google Drive
BSD 3-Clause "New" or "Revised" License
400 stars 76 forks source link

It would be more useful to configure GOOGLE_DRIVE_CLIENT_ID as env var #132

Closed dirkcgrunwald closed 1 year ago

dirkcgrunwald commented 6 years ago

I'm deploying a new jupyterhub / lab setup. I'm using the helm chart. This creates a persistent file system for each user.

The existing solutions for setting an appropriate GOOGLE_DRIVE_CLIENT_ID for a specific implementation do not work in this case because the file system already exists, you can't echo into it (or it doesn't seem to work) and you can't set it up as a "default" because the PV mountpoint will overwrite whatever is in jupyter.

If the google drive JS code checked for GOOGLE_DRIVE_CLIENT_ID this would eliminate the problem and arguably be more flexible.

ian-r-rose commented 6 years ago

Hi @dirkcgrunwald, sorry for the slow response.

I agree that it would be more convenient to be able to specify the client id as an environment varaiable. The problem with that is that it would then require a server-side component to this extension in order to access the variable, and to communicate that to the front-end. This would make the maintenance of the extension more complex, and would add more steps to the install process. I am pretty reticent to do that when the current solution (using the settings system) works, even if it is a bit awkward.

I am a bit puzzled as to why setting up an environment with a settings file in the appropriate place is not working. Do you not have the ability to seed your user environments with specific files?