search

jupyterlab / jupyterlab-hdf5

Open and explore HDF5 files in JupyterLab. Can handle very large (TB) sized files, and datasets of any dimensionality
BSD 3-Clause "New" or "Revised" License
115 stars 27 forks source link

Double clicking above the files of the FileBrowser still opens the file #140

Closed cnydw closed 1 year ago

cnydw commented 1 year ago

Description

brave_bumDo3bcoY

When you have many files in a folder that you can scroll down in the file browser, then you double click on the area above the DirListing widget, the file is still opened.

Reproduce

Like the description

Expected behavior

The file shouldn't be opened.

Context

https://github.com/jupyterlab/jupyterlab-hdf5/blob/e115077ef70d251005589a36df8d9643c1c3a7e5/src/browser.ts#L96 patches the whole browser node, which includes the filter and other components above the DirListing widget. It should only patch the DirListing widget's node.