Disable PDF open or reveal to avoid error 404 when pdflatex failed

jupyterlab / jupyterlab-latex

JupyterLab extension for live editing of LaTeX documents

BSD 3-Clause "New" or "Revised" License

622 stars 69 forks source link

Disable PDF open or reveal to avoid error 404 when pdflatex failed #95

Closed vacoa closed 6 years ago

vacoa commented 6 years ago

These changes seem to fix the error panel bug #80 for me.

The cleanup line pdfContext.disposed.connect(cleanupPreviews) in the function findOpenOrRevealPDF() was closing the error panel when the pdfContext was disposed because the PDF was not found, I guess... Therefore, everytime a pdflatex error occurs, I disable findOpenOrRevealPDF() in onFileChanged().

Not sure this is the best way to do, it might be better to directly change the cleanupPreviews() function...

ian-r-rose commented 6 years ago

Sorry to be slow @jahsue78, I haven't forgotten about this! I'll be able to get to it this week.

vacoa commented 6 years ago

No problem @ian-r-rose

vacoa commented 6 years ago

Thanks for the simplification @ian-r-rose . This is indeed better. I just pushed your requested changes.

ian-r-rose commented 6 years ago

Thanks for the fix @jahsue78!