search

jupyterlab / jupyterlab-shortcutui

A JupyterLab extension for managing keyboard shortcuts
BSD 3-Clause "New" or "Revised" License
54 stars 15 forks source link

Rendered shortcuts assume you are using a Mac #36

Closed ian-r-rose closed 6 years ago

ian-r-rose commented 6 years ago

The shortcuts that use the Accel key are rendered as Cmd, or ⌘

NoahStapp commented 6 years ago

Hi Ian,

How does the command palette handle Accel keys on windows? Does it display it as Control or the Windows key?

NoahStapp commented 6 years ago

This should be fixed in the most recent version, can you confirm?

ian-r-rose commented 6 years ago

Thanks! I just checked, and things seem to be working as expected.

Phosphor just today exposed a new function in phosphorjs/phosphor#358 to automatically render a keyboard shortcut (with all the mac/windows/linux stuff handled automatically). If you want to remove the responsibility of handling that logic yourself, you may want to investigate using that.

ian-r-rose commented 6 years ago

Closing as fixed.