search

jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
14.08k stars 3.31k forks source link

Indic font in JupyterLab terminal not rendering correctly #15856

Open vivian-rook opened 6 months ago

vivian-rook commented 6 months ago

Description

curl --silent "https://en.wikipedia.org/w/index.php?title=Malayalam_Wikipedia&oldid=1195587528" 2>&1 | grep "മലയാളം" in the terminal of JupyterLab Assuming the browser you are using is rendering Indic font correctly "മലയാളം" will appear incorrectly in JupyterLab

Expected behavior

Font should render correctly

Context

Zero to jupyterhub Chart version: 3.2.1 JupyterLab version: 4.1.2

vivian-rook commented 6 months ago

A little more context can be found https://phabricator.wikimedia.org/T355998

krassowski commented 6 months ago

JupyterLab uses xterm.js as a terminal implementation, maybe there is something relevant in the xterm.js issues (https://github.com/xtermjs/xterm.js/issues)?

vivian-rook commented 6 months ago

https://github.com/xtermjs/xterm.js/issues/4867 and perhaps https://github.com/xtermjs/xterm.js/issues/4830 do seem relevant. Thank you.

krassowski commented 6 months ago

Thanks for the link! Once this is fixed on xterm side we can update our versions to pull the fix.