Migrate shortcuts search to use `FilterBox`

jupyterlab / jupyterlab

JupyterLab computational environment.

https://jupyterlab.readthedocs.io/

Other

13.81k stars 3.12k forks source link

Migrate shortcuts search to use `FilterBox` #16216

Closed krassowski closed 2 weeks ago

krassowski commented 3 weeks ago

References

Fixes #16215

Code changes

makes use of FilterBox which uses jupyter-ui-tookit for search component in shortcuts UI (follow up to https://github.com/jupyterlab/jupyterlab/pull/16046)
fixes style of advanced options links,
adds missing cursor pointer styles
removes unused jp-Shortcuts-AdvancedOptionsSmall and jp-Shortcuts-AdvancedOptionsRight styles

User-facing changes

Before	After

Filtered down, small window (see how previously "Reset All" was oddly spread across two lines - now fixed by adding display: inline-block)

Before	After

Backwards-incompatible changes

jupyterlab-probot[bot] commented 3 weeks ago

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link:

krassowski commented 3 weeks ago

@kolibril13 how does this one look on Binder in Safari?

kolibril13 commented 3 weeks ago

looks good!

only the text overlap in the second shortcut option and "Default" remains:

krassowski commented 3 weeks ago

only the text overlap in the second shortcut option and "Default" remains:

I don't know how to fix this at the moment - I would need access to Safari and right now can only run one via remote desktop which is super slow, so I would defer to someone who uses Mac to pick it up in a separate PR (though again, this looks like a Safari bug).

jtpio commented 2 weeks ago

Looks like we can still get this PR merged as an improvement, and track the remaining Safari bug in a separate issue?