Open gderocher opened 3 weeks ago
Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link:
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks for starting this @gderocher. To make it show up conditionally you will need to add something like:
.jp-mod-kernel-widget .jp-RunningSessions-item-label-kernel-id {
display: none;
}
.jp-mod-running-list-view .jp-mod-kernel-widget .jp-RunningSessions-item-label-kernel-id {
display: inline;
}
It also looks like this PR needs rebasing or merging with the main branch to resolve conflicts.
We tried to merge the files with main and resolve the conflict, but it seems to be treating the commit as separate items. Let us know if we should create a new pull request, or if you have any ideas to fix it. Thank you.
I would suggest you try rebasing on main
and force push to this PR.
Should have the merge all set now. Should we do anything to remove all the extra tags that got added in the mishap?
This looks like a problem with labeler - it should remove the labels automatically.
References
15991
Code changes
Added name() function to return the name of children (previously done by label). Reimplemented label function to display kernel ID through a ReactNode.
User-facing changes
Kernel ID displays for all notebooks and consoles in both list and tree view. Planning on updating so the ID only shows in list view.
After Changes: