jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.81k stars 3.12k forks source link

updated shutdown dialogue to display app.name #16229

Closed sawickid closed 2 weeks ago

sawickid commented 2 weeks ago

References

https://github.com/jupyter/notebook/issues/7188 "File > Shutdown in classic notebook ask if I want to shutdow JupyterLab"

Code changes

Edits shutdown dialogue body to ask if the user wants to shutdown , instead of exclusively 'JupyterLab'

User-facing changes

User will be prompted to confirm shutdown of Jupyter Notebook, instead of JupyterLab, when using Jupyter Notebook

jupyterlab-probot[bot] commented 2 weeks ago

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

welcome[bot] commented 2 weeks ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada: