jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.81k stars 3.12k forks source link

Use the application name instead of hard-coded "JupyterLab" in dialogs/commands #16230

Closed sawickid closed 2 weeks ago

sawickid commented 2 weeks ago

References

https://github.com/jupyter/notebook/issues/7188 "File > Shutdown in classic notebook ask if I want to shutdow JupyterLab"

Code changes

Edits shutdown dialogue body to ask if the user wants to shutdown , instead of exclusively 'JupyterLab'

User will be prompted to confirm shutdown of Jupyter Notebook, instead of JupyterLab, when using Jupyter Notebook

jupyterlab-probot[bot] commented 2 weeks ago

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

welcome[bot] commented 2 weeks ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: