jupyterlab / jupyterlab

JupyterLab computational environment.
https://jupyterlab.readthedocs.io/
Other
13.81k stars 3.12k forks source link

Use "Folder", not "Directory", in file browser settings #16231

Closed JasonWeill closed 2 weeks ago

JasonWeill commented 2 weeks ago

Problem

Although directory is used in command names, our UI uses folder in the file browser:

image

(Note that the above command is "create-new-directory", thanks @andrii-i for the screenshot)

Two settings in the advanced settings editor, "Navigate to current directory" and "Filter directories", use directory, not folder.

image

Proposed Solution

Use folder consistently in the user interface. Renaming commands is not necessary.

Additional context

Rob-P-Smith commented 2 weeks ago

I am done with the change requested and verified desired behavior.

I can't submit a pull request yet as it's not assigned/traiged etc.

folder

JasonWeill commented 2 weeks ago

@Rob-P-Smith Thank you so much for your interest! Please feel free to open a pull request when you're ready.

krassowski commented 2 weeks ago

Closing as fixed by https://github.com/jupyterlab/jupyterlab/pull/16234.