Closed Rob-P-Smith closed 2 weeks ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link:
I must be missing something, but I can't see where I would add the label to this pull request to satisfy the Enforce PR label test.
I must be missing something, but I can't see where I would add the label to this pull request to satisfy the Enforce PR label test.
https://jupyterlab.readthedocs.io/en/stable/developer/contributing.html#tagging-issues-with-labels (maybe docs should also mention that it also applies to PRs? If you agree PR welcome!)
@meeseeksdev tag enhancement
Krassowski, Thanks for helping a new contributor figure it out; I must have skimmed right past that. Mea culpa for failing at RTFM.
On to a more meaningful task now!
I accidentally pushed without branching for another issue, and it upset this PR. Sorry for the mistake, git voodoo is not yet a strong point.
I'm not sure how to safely revert the mess it created here; my apologies for any extra work created.
I think we should also update documentation for consistency, in particular docs/source/user/files.rst but possibly other pages in User Guide as well.
I accidentally pushed without branching
No worries, we do squash merge anyways.
Fixed mangled commit from earlier, and adjusted docs per request.
bot please update snapshots
Documentation snapshots updated.
Galata snapshots updated.
Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:
Adjusted wording to satisfy issue #16321
References
This addresses rewording requested in #16231
Code changes
Adjusted the labeling on file browser display from 'directory' to 'folder' in /filbrowser/schema/browser.json
User-facing changes
Changes seen here
Backwards-incompatible changes
This should not cause any issues with backwards compatibility.